search

gaurav-nelson / asciidoc-reference-check

Atom package to check if all the references in the current document are valid.
https://atom.io/packages/asciidoc-reference-check
MIT License
2 stars 3 forks source link

support external references without file extension #4

Closed fritz-hh closed 6 years ago

fritz-hh commented 6 years ago

Add support for the following type of inter-document cross references: <<document-b.adoc#,Section B>> <<document-b#,Section B>> (without the optional extension) <<document-b.adoc,Section B>> (without the # sign)

(see https://asciidoctor.org/docs/user-manual/#inter-document-cross-references)

gaurav-nelson commented 6 years ago

Thanks you for the PR @fritz-hh

I will test this and merge soon.

fritz-hh commented 6 years ago

Cool, thanks a lot!

gaurav-nelson commented 6 years ago

@fritz-hh I do not see a case without the .aodc extension in https://asciidoctor.org/docs/user-manual/#inter-document-cross-references.

Currently, it handles Refer to <<./document-b.adoc#section-b,Section B>> for more information. (It might need updates to resolve path better like you suggested in #5 )

Can you please check it again?

fritz-hh commented 6 years ago

Sorry for posting the wrong link... ommiting adoc is indeed supported (at least by asciidoctor). It is described here (at the very end of the section): https://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#links

Inter-document cross references (Asciidoctor only)

Refer to <<document-b.adoc#section-b,Section B>> for more information.

See you when you get back from <<document-b#section-b,Section B>>!

gaurav-nelson commented 6 years ago

Thanks @fritz-hh works perfectly, merging this now.

fritz-hh commented 6 years ago

Thanks you!