search

gaurav-nelson / github-action-markdown-link-check

Check all links in markdown files if they are alive or dead. 🔗✔️
MIT License
399 stars 77 forks source link

Fix defaults handling, perform linting #153

Closed sammcj closed 1 year ago

sammcj commented 1 year ago

This PR is for two things:

  1. Currently when trying to use this Action linting/actionlint fails because all optional inputs are marked as required: true.

Screen Shot 2022-09-20 at 9 05 52 am

I have refactored the bash parameters to set the defaults if no input is provided, and set the inputs to optional.

  1. Fixed numerous markdown formatting errors.

cc/ @gaurav-nelson

sammcj commented 1 year ago

The two markdown link errors are both false positives @gaurav-nelson

Screen Shot 2022-09-21 at 7 52 32 am

sammcj commented 1 year ago

@gaurav-nelson do you know what's up with those false positive link checks?

gaurav-nelson commented 1 year ago

For GitHub can you see https://github.com/gaurav-nelson/github-action-markdown-link-check/issues/136#issuecomment-1117148640 and add it to the mlc-config file ?

The other one is probably disallowing agents. maybe add it to ignore list as well.

sammcj commented 1 year ago

@gaurav-nelson thanks, done :)

gaurav-nelson commented 1 year ago

@sammcj Can you please check the script again, I think the failed workflow is not running with the --config option. I am not sure though.

Also, See https://github.com/gaurav-nelson/github-action-markdown-link-check/actions/runs/3140346552/jobs/5101650177#step:3:154 which outputs the command we are running however the failed check doesn't list the command https://github.com/gaurav-nelson/github-action-markdown-link-check/actions/runs/3140346552/jobs/5101650203? 🤔

sammcj commented 1 year ago

@gaurav-nelson Oh I see what's going on, it's relying on on all inputs being provided in order to have each parameter in the right place.

OK I'll refactor!