search

gaurav-spacreo / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

3rd-party: JSMinPlus 1.3 exhausts memory #159

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
2 users have complained that JSMin+ exhausts PHP's memory. 
http://www.google.com/url?sa=D&q=http://groups.google.com/group/minify/browse_th
read/thread/6f98e6462b2e2d65&usg=AFQjCNF0Jt8UevopaOx-6NY49qF3mNzC4Q
http://groups.google.com/group/minify/browse_thread/thread/64a8579f8add029e

My suggestion is to remove the singleton instance, allowing all the objects
to be GCed when ::minify() returns. Simply replace (line 118 of v1.3):

static $instance;

with:

$instance = false;

Neither user has notified me if this helped...

Original issue reported on code.google.com by mrclay....@gmail.com on 3 Feb 2010 at 8:12

GoogleCodeExporter commented 9 years ago 
This may not be due to the static, but rather the memory intensive design.
http://crisp.tweakblogs.net/blog/1856/jsmin+-version-13.html#r_35237

Only workaround is raising PHP's memory limit...

Original comment by mrclay....@gmail.com on 3 Feb 2010 at 8:16