search

gauravk95 / audio-visualizer-android

🎵 [Android Library] A light-weight and easy-to-use Audio Visualizer for Android.
Apache License 2.0
857 stars 132 forks source link

CircleLineVisualizer #6

Closed wangfengye closed 5 years ago

wangfengye commented 5 years ago

I want create a Visualizer like 动感音阶, this is a demo ,I want we can finish it together

gauravk95 commented 5 years ago

Hi @wangfengye,

Nice one, Thanks for the contribution!

I went through the code, logic wise the code looks good, but needs some improvement:

  1. Code quality(formatting, comments not in English, unused imports etc) -
    • Try to format the code better Tip: Ctrl+Alt+L(Win), give appropriate breaks, and try not to define inner class in middle and declare variables in middle(you can move those to top or bottom)
    • Remove unused imports and the Log Statements
    • If possible change the comments to English
  2. HifiVisualizer is random and does not change with the audio, which we will need to fix.
  3. Sample needs to updated i.e. buttons are not aligned properly

I will approve the pull request once the above are sorted!

Thanks again for your contribution.