Fix Filled Area/Zone not copying

gauravmm / HierarchicalPcb

MIT License

32 stars 6 forks source link

Fix Filled Area/Zone not copying #4

Closed i404788 closed 8 months ago

i404788 commented 1 year ago

Adds support for Fill Areas/Zones
Fixes via nets not always matching
Fixes arc mid point not being transformed resulting in straight lines usually
Fixes net issues with areas/vias

gauravmm commented 1 year ago

Thanks for the pull request! I'll dig through it and merge it ASAP.

i404788 commented 1 year ago

:+1:, Note there is still a known issue that I'm working on with Named Areas (using labels) having \/\<Net> while pads/traces have \/\<Subboard>/\<Net> meaning they will seperate when recalculating fills.

gauravmm commented 12 months ago

Hey, thanks for the pull request! I've made some small changes and pushed my version up to branch pullreq4. Could you please merge those into your master branch and make changes based on that?

I have a question: do we need to clear Area objects in clear_traces? (Also, can area objects be members of groups?)

Once again, thanks for the help!

i404788 commented 12 months ago

I believe the Area would duplicate when regenerating if not in clear_traces. Also they can indeed be members of groups. I'll merge you changes.

gauravmm commented 8 months ago

Thank you for the pull request!