gauravsingh1281 / Rentalog.in--Frontend

Rentalog || Free Rent Management Web App For Landlords. With Rentalog, landlords can keep track of important information about their renters, including their names, addresses, and rental payment history.
https://visionary-fenglisu-db1b1d.netlify.app/
MIT License
95 stars 251 forks source link

fixed navbar responsiveness #38

Closed vashukashyap closed 1 year ago

vashukashyap commented 1 year ago

What this PR do?

21 fixed Navbar responsive for both desktop and mobile.

Expected behaviour.

the Navbar should display properly on desktop and mobile

Additional info.

Desktop

Screenshot (16)

Mobile

Screenshot (17) Screenshot (18)

netlify[bot] commented 1 year ago

Deploy Preview for visionary-fenglisu-db1b1d ready!

Name Link
Latest commit b23132989e1b8a4a685ce6aca3a96889f6245a1c
Latest deploy log https://app.netlify.com/sites/visionary-fenglisu-db1b1d/deploys/652adfdf9892c800087ba4f9
Deploy Preview https://deploy-preview-38--visionary-fenglisu-db1b1d.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vashukashyap commented 1 year ago

Kindly check my PR please

vashukashyap commented 1 year ago

I have committed the changes, can you review it please

gauravsingh1281 commented 1 year ago
Screenshot 2023-10-14 200757 Screenshot 2023-10-14 200901

Hii @vashukashyap rentals nav links missing in the navbar and I want the above mobile design for mobile view.

vashukashyap commented 1 year ago

I have modified the Navbar , please review now.

gauravsingh1281 commented 1 year ago

I have modified the Navbar , please review now.

@vashukashyap please resolve merge conflict.

vashukashyap commented 1 year ago

I have resolved the merge conflict. review it please!

gauravsingh1281 commented 1 year ago

Thank you for your contribution @vashukashyap

vashukashyap commented 1 year ago

thankyou sir, is there any other issue where I can help?