search

gauravsoni119 / ng2-tel-input

MIT License
56 stars 57 forks source link

Upgarde peerDependency to 5.2.3 to be able to work in Angular 5 app. #13

Closed chaabenMohamed closed 6 years ago

chaabenMohamed commented 6 years ago

this commit is needed to Fix this bug: Uncaught Error: Unexpected value 'Ng2TelInputModule' imported by the module 'AppModule'. Please add a @NgModule annotation.

gauravsoni119 commented 6 years ago

Hi @chaabenMohamed , Firstly thanks for this pull request. I tried your code on my local. I got some errors. I attached an image of errors. Have you get these errors? I think these errors are related to types of jquery. I am trying to fix these.

error_pull_request

chaabenMohamed commented 6 years ago

Hello @gauravsoni119, for me I have another error: screenshot from 2018-03-19 15-29-38

chaabenMohamed commented 6 years ago

After removing jquery and @angular/core from dependencies, every thing work well, I think in your error you should just remove jquery from dependecies

gauravsoni119 commented 6 years ago

Hi @chaabenMohamed, I fixed the issue and pushed it. The issue is also related to code.

chaabenMohamed commented 6 years ago

Hier @gauravsoni119, good work, but I think it's best tout use keyup instead if using Blur event, to Can checkbox wrong phone number un Real Time.