gauravsoni119 / ng2-tel-input

MIT License
56 stars 57 forks source link

Not working with ivy #58

Closed bendg25 closed 4 years ago

bendg25 commented 5 years ago

ng2-tel-input.module.js(22,27): error TS-991010: Value at position 0 in the NgModule.declarations of Ng2TelInputModule is not a reference: [object Map]

bendg25 commented 4 years ago

Seems to work with latest Angular 9 -> RC.6

bendg25 commented 4 years ago

Value at position 0 in the NgModule.declarations of Ng2TelInputModule is not a reference: [object Object] . scrap that, issue is still there

gauravsoni119 commented 4 years ago

@bendg25 Thanks for raising the issue. I am looking into this issue. I am going through couple of issues and articles on GitHub such as:- https://github.com/angular/angular/issues/32025 https://medium.com/@sarunint/how-can-you-experimentally-try-angular-ivy-right-now-c23930062b4c

It seems like the package is not according to the standards of the angular.

bendg25 commented 4 years ago

Hi, yes that is as far as I got with it. It was not immediately obvious what Angular is not happy about.

Yolo-plop commented 4 years ago

Awaiting an official fix, there a very easy workaround:

The plugin works, it's just the js compilation that Angular is not happy with. I'm not surprised, js is beyond crap.

xadim commented 4 years ago

Hello @gauravsoni119 do you have a workaround for this issue please?

Hello @Dt-Sodium importing the .ts file raised other issues on my end, maybe I was not doing it right. Can you please share your workaround code? Thanks-

Yolo-plop commented 4 years ago

I'm not even sure we still use this, another developer finished the telephone number form. If i remember correctly, i just copied the source .ts file somewhere in my project and imported the class from there.

aceleghin commented 4 years ago

Hey, any news?

Still have this issue...anyone has at least a workaround? with 2.1 I don't have this error

gauravsoni119 commented 4 years ago

The new version of the package is aligned with Angular package format which makes it compatible with all angular versions.