.NET resumable uploads not implemented correctly

GoogleCodeExporter commented 8 years ago

Hi,

Looking through the source code of resumableupload.cs (around line 540) it does 
not implement the Google protocol properly, especially the handling of "308 
continue" or the "Location" as described here:
http://code.google.com/apis/gdata/docs/resumable_upload.html

"308 continue" is not just an Ack, it needs to be parsed.

This means that it is buggy for large files and unreliable connections, which 
is the reason for using resumable uploads in the first place.

It also seems like the index calculation is incorrect.  The variable 
"chunkstart" is always = 0.  This means that it only ever works with small 
chunks that bypass this logic!  

With very small chunks, the .NET library buffers all the data before sending 
it.  The resumable uploader reaches 100% progress once this buffer is full, not 
once the data is all sent.  It then completes once the buffer is emptied.

This is probably one for Frank Mantek.

A fix would be appreciated.

Andrew

Original issue reported on code.google.com by andrew.f...@gmail.com on 7 Oct 2010 at 12:19

GoogleCodeExporter commented 8 years ago

[deleted comment]

GoogleCodeExporter commented 8 years ago

Discussion moved to 
http://www.google.com/support/forum/p/apps-apis/thread?tid=55096dccbc810ae3

Original comment by andrew.f...@gmail.com on 20 Oct 2010 at 6:32

GoogleCodeExporter commented 8 years ago

Issue 407 has been merged into this issue.

Original comment by ccherub...@google.com on 8 Nov 2010 at 4:23

GoogleCodeExporter commented 8 years ago

This was just fixed in rev. 1049.
Kudos to Andrew Fields for his patch.

Original comment by ccherub...@google.com on 18 Nov 2010 at 5:31

Changed state: Fixed

gauravtyagi2777 / google-gdata

.NET resumable uploads not implemented correctly #431