search

gaurishhs / elysia-ip

Get Client IP Address in Elysia
MIT License
50 stars 10 forks source link

Duplicate run when use multiple time & Add injectServer & Remove throw error it make app crash #18

Closed armada45-pixel closed 4 months ago

armada45-pixel commented 4 months ago

Duplicate when use multiple time. Fix by using new Elysia() and name it using Elysia({ name: "elysia-ip" })

Planing add option injectServer like https://github.com/rayriffy/elysia-rate-limit/blob/main/example/muliInstanceInjected.ts for fix issue like https://github.com/rayriffy/elysia-rate-limit/issues/29

Remove throw error it make app crash https://github.com/gaurishhs/elysia-ip/blob/f46952e0baa39e63aaabe19a2ada291e8ee87036/src/index.ts#L49

Fixed in Fork https://github.com/armada45-pixel/elysia-ip/blob/main/src/index.ts

gaurishhs commented 4 months ago

I don't see any changes in the fork

armada45-pixel commented 4 months ago

Wait for Example. After that i will create pull request. Right now i'm so busy.

armada45-pixel commented 4 months ago

Duplicate https://github.com/armada45-pixel/elysia-ip/blob/7822c81fe9490b4bf1c235cd29465dfcc8151a0d/example/issue.ts#L18-L42 image

armada45-pixel commented 4 months ago

Remove throw error https://github.com/gaurishhs/elysia-ip/blob/f46952e0baa39e63aaabe19a2ada291e8ee87036/src/index.ts#L49

armada45-pixel commented 4 months ago

Fixed https://github.com/gaurishhs/elysia-ip/issues/14