search

gaurishhs / elysia-session

Sessions plugin for Elysia
MIT License
20 stars 2 forks source link

Updated elysia-session so it works as expected #4

Closed jkelkar closed 1 month ago

jkelkar commented 5 months ago

Hi, I needed this plugin but never got it to work with saving data. I am new to elysia and to the best of my knowledge I have updated your code to enable saving and accessing data saved in session. Update your repo if you find it useful. I am using the changed version in projects and it seems to work well.

Regards, Jay Kelkar P.S. Thanks for getting this started.

ultimateshadsform commented 1 month ago

Any news on this? Is this going to be merged? I tried basic code but it doesn't save the session state and creates a new session on every page load.

jkelkar commented 1 month ago

Looks like you may be right. I will release a new repo when I can, currently it is not a priority.

Jay

On Aug 20, 2024, at 14:36, Alexander @.***> wrote:

I don't think this is going to be updated anymore. It's probably better to just upload to a new repo and just create a new npm package since original repo owner doesn't update or accept PRs.

— Reply to this email directly, view it on GitHub https://github.com/gaurishhs/elysia-session/pull/4#issuecomment-2299498372, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAENSSO44F4OHFYFGUUU22LZSOEBXAVCNFSM6AAAAABG3EG2TGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJZGQ4TQMZXGI. You are receiving this because you authored the thread.

gaurishhs commented 1 month ago

hi, i haven't opened github for a while (exams), I don't think so i ever got an email for this PR. i will merge your PR asap.

jkelkar commented 1 month ago

Yes, typescript can be moved to devDependencies. By the way, the solution I have proposed is ok, but not perfect. I have abandoned this approach and am using fastify to finish my project, it has a reliable session package.

I also found elysia a bit hard to work with in its present state for use in a complex server.

On Aug 20, 2024, at 21:49, Gaurish Sethia @.***> wrote:

@gaurishhs commented on this pull request.

In package.json https://github.com/gaurishhs/elysia-session/pull/4#discussion_r1724181444:

@@ -79,6 +79,7 @@ }, "dependencies": { "iron-webcrypto": "^0.10.1",

  • "nanoid": "^5.0.1"
  • "nanoid": "^5.0.1",
  • "typescript": "^5.4.5" Can typescript be moved to devDependencies?

— Reply to this email directly, view it on GitHub https://github.com/gaurishhs/elysia-session/pull/4#pullrequestreview-2249404026, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAENSSKNF3AZ6S2Q2YLPPF3ZSPW4FAVCNFSM6AAAAABG3EG2TGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBZGQYDIMBSGY. You are receiving this because you authored the thread.

gaurishhs commented 1 month ago

No issues. I'll merge this PR and make the necessary changes

jkelkar commented 1 month ago

Thanks.

Regards, Jay

On Wed, Aug 21, 2024 at 06:06 Gaurish Sethia @.***> wrote:

Merged #4 https://github.com/gaurishhs/elysia-session/pull/4 into main.

— Reply to this email directly, view it on GitHub https://github.com/gaurishhs/elysia-session/pull/4#event-13957927948, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAENSSJ3TKRD33XIUAWJQKLZSRRDXAVCNFSM6AAAAABG3EG2TGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTHE2TOOJSG44TIOA . You are receiving this because you authored the thread.Message ID: @.***>