gausby / tortoise

A MQTT Client written in Elixir
Apache License 2.0
314 stars 54 forks source link

Use Clean-Session from Connection Options #135

Closed DerTim1 closed 5 months ago

DerTim1 commented 3 years ago

The Option clean_session is already implemented, but always set to true.

This PR adds 2 lines to be able to set clean_session as false with connection_options.

Unfortunately I can't run tests with Elixir 1.10, because the QuickCheck library can't be downloaded (is fixed in eqc, but not released yet, see https://github.com/Quviq/eqc_ex/commit/1e8367293a06de050bbceffc53ac2aca7696dae7) and a further problem in eqc_ex.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 4


Totals Coverage Status
Change from base Build 57: 0.0%
Covered Lines: 576
Relevant Lines: 657

💛 - Coveralls
DerTim1 commented 3 years ago

Ping... This is trivial fix. Can we merge that?