search

gausby / tortoise

A MQTT Client written in Elixir
Apache License 2.0
314 stars 54 forks source link

Remove the defdelegate for subscriptions from to module #80

Closed gausby closed 6 years ago

gausby commented 6 years ago

While it is good to be able to subscribe and unsubscribe from topics during the connections life cycle I think it is better to encourage setting the topics in the connection specification (using subscriptions: […]), or updating subscriptions in the user specified handler function.

If the defdelegate is removed the subscribe and unsubscribe functions will be a bit hidden, but still accessible.

When applied this will fix #64