gausby / tortoise

A MQTT Client written in Elixir
Apache License 2.0
314 stars 54 forks source link

Add an example handler to README to help get started beginners #83

Closed tanweerdev closed 6 years ago

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 4


Files with Coverage Reduction New Missed Lines %
lib/tortoise/package/connect.ex 1 88.24%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 24: -0.2%
Covered Lines: 565
Relevant Lines: 643

đź’› - Coveralls
gausby commented 6 years ago

Don't worry about the decreased code coverage…coveralls seems to act up once in a while.

I think it is a good thing to have an example of a handler in the documentation, but I think it should be moved to the bottom of the example section—the following paragraph is part of connecting using the SSL transport. Please fix this and I will merge the PR.

tanweerdev commented 6 years ago

Sure

tanweerdev commented 6 years ago

I have updated and pushed my commit (forcefully). Please review now and let me know if you want some more updates

gausby commented 6 years ago

The line «Look at the connection_test.exs-file for more examples.» belong to the SSL example as well. Please move that up as well.

tanweerdev commented 6 years ago

@gausby Done

gausby commented 6 years ago

Thanks, released in v0.9.1