search

gausma / nodered-contrib-signal-client

Signal communicator client nodes for Node-RED
GNU General Public License v3.0
33 stars 13 forks source link

Downstream proxy-agent dependency causing issues with other modules #36

Open skylord123 opened 2 years ago

skylord123 commented 2 years ago

I'm the developer of node-red-contrib-matrix-chat and someone reported an issue with HTTP requests failing. It was redirecting their HTTP requests to 127.0.0.1:443 instead of the actual requested URL.

I use the got library in my module which is also what Node-RED uses. It is a known issue that http[s]-agent-proxy packages can break URLs (which proxy-agent depends on). See here: https://github.com/sindresorhus/got/issues/1572

After the person having the issue uninstalled nodered-contrib-signal-client from Node-RED the requests started working again.

skylord123 commented 2 years ago

I did some more digging and it looks like gausma/libsignal-service-javascript is using an old version of proxy-agent that causes this. I commented on an issue over there to get it resolved: https://github.com/gausma/libsignal-service-javascript/issues/3