Download images sequentially

gautamdhameja / medium-2-md

A CLI tool that converts exported Medium posts (html) to Jekyll/Hugo compatible markdown with front matter.

https://www.npmjs.com/package/medium-2-md

Apache License 2.0

142 stars 19 forks source link

Download images sequentially #21

Closed djensen47 closed 3 years ago

djensen47 commented 3 years ago

When there are many posts and many images per post, it can result in connection timeouts. This is due to using Promise.all and attempting to fetch all the images at the same time. This PR changes the processing to be sequential. Fixes #9

djensen47 commented 3 years ago

@gautamdhameja Any chance we can get this and #20 merged soon-ish? I have some other PRs that I'm working on that I'd like to submit this weekend. Thanks!

gautamdhameja commented 3 years ago

@djensen47 Done. Merged both PRs. It seems the other PR #20 had some changes from this one too. I've resolved those conflicts. For now, I'll keep these in master and will make a release after I test the changes. Thanks a lot for your contributions. :)

djensen47 commented 3 years ago

Awesome, thanks!