gautamkrishnar / motrix-webextension

A browser extension for the Motrix Download Manager
GNU General Public License v3.0
1.21k stars 97 forks source link

BrowserDownloader Object Seems to trigger an infinite loop condition in Firefox #108

Open AyoungDukie opened 1 year ago

AyoungDukie commented 1 year ago

Apologies for the slew of activity, but have continued my debugging efforts for now.

There seems to be an issue created when downloading a file that matches the Blacklist settings (at least in Firefox) where the download seems to work properly, but the console shows that each time a new file gets downloaded via the browser (a new "BrowserDownloader" object is made), there begins an infinite... retry? As an example, this console output will be repeated every 1-2 seconds:

image

I was testing using the blacklist for "pdf" files. I tested the blacklist/file combo in Chrome, Edge (both 22.1.7, so before the browser download support I think), and Firefox. For all three, this file would successfully download without using Motrix, but for Firefox the above is triggered.

Starting a new download seems to make a new object, which will additionally begin another infinite loop concurrently.

For now this doesn't seem to cause direct issues, but a side effect seems to be that some of the interface seems to stop behaving (e.g. the download indicator never shows that it has begun a download nor does it show when item complete. The file will show in the list/history, however).

I am quickly getting beyond my limited background with javascript/browser debugging, but let me know if there is more info I can try to give that could help.