gautamkrishnar / motrix-webextension

A browser extension for the Motrix Download Manager
GNU General Public License v3.0
1.21k stars 97 forks source link

feat: Add cookies support #118

Closed CW-B-W closed 1 year ago

CW-B-W commented 1 year ago

Feature

Add cookies support for downloading files that requires cookies (e.g. Google Drive)

Related to: #20, #113

Description

I've tested this with Google Drive(& Google Docs), OneDrive, Dropbox and iCloud files, it successfully sent and downloaded the files on the abovementioned services with Motrix.

NOTICE

gautamkrishnar commented 1 year ago

@CW-B-W thanks a lot for the contribution, please let me know once this is ready for review. Please note that there are also some known issues with the code on the master branch due to manifest v3 migration which I am trying to fix when I have time. This may delay the release of this code. For manifest v3 extensions, the service worker won't always stay alive so the extension need to be converted to more of an event-driven approach

CW-B-W commented 1 year ago

Hello @gautamkrishnar,

It's ready for your review, thanks!

And about

For manifest v3 extensions, the service worker won't always stay alive so the extension need to be converted to more of an event-driven approach

I am trying to resolve this issue with this Persistent Service Worker in Chrome Extension. I've tested it for an hour and it still works fine. (service worker is still alive, and can send tasks to Motrix successfully)

I will open a new PR when I think it's ok.

gautamkrishnar commented 1 year ago

Thanks a lot for contributing this @CW-B-W. Will test it out.