search

gautamkrishnar / motrix-webextension

A browser extension for the Motrix Download Manager
GNU General Public License v3.0
1.21k stars 97 forks source link

Fix for firefox #65

Closed JaroslawPokropinski closed 2 years ago

JaroslawPokropinski commented 2 years ago

Extension does not work in firefox. To fix that it is checked if filename is set on creation. There are also some minor changes

JaroslawPokropinski commented 2 years ago

Firefox also wants addon to have id so i set it to 'motrix-webextension@gautamkrishnar.com'

gautamkrishnar commented 2 years ago

@JaroslawPokropinski can you please rebase the PR, you can also re-open a new one with just the changes.

JaroslawPokropinski commented 2 years ago

It should be fine now. I merged master and resolved conflicts.

gautamkrishnar commented 2 years ago

@JaroslawPokropinski https://extensionworkshop.com/documentation/develop/extensions-and-the-add-on-id/ extension ID is no longer required. We cant use it since the add on is already published. Release step is failing https://github.com/gautamkrishnar/motrix-webextension/runs/3976677145?check_suite_focus=true

JaroslawPokropinski commented 2 years ago

It seems that the id is set automatically for deploy now. Debugging for Firefox without explicit id fails as storage API still requires it.

gautamkrishnar commented 2 years ago

Yep for debugging you can manually set it.