search

gautamramk / FQ-PIE-for-Linux-Kernel

GNU General Public License v3.0
29 stars 4 forks source link

coding style issues #3

Open dtaht opened 5 years ago

dtaht commented 5 years ago

1) I can't remember if you are the same group trying to update pie to match the rfc?

2) You have severe codingstyle problems, notably a 4 char indent where linux would use tabs. Things like && should be at the end of the line, not the beginning, and so on. checkpatch barfed big time. emacs and vi have modes for doing this more right, I am not sure if clang-format always gets it right.

What I did to check that was add in sch_fq_pie.c and pie.h into the net-next tree, commit them, then do a git format-patch that commit, then run scripts/checkpatch.pl on the result. You won't get reviewers unless you squash all the checkpatch errors.

Aside from that, well, I was never fond of the jiffies thing that pie did, however my suggestion would be to get it through checkpatch, then submit to net-next in this window since I haven't been able to raise interest on the bloat list, and you will hopefully get constructive feedback and have a learning experience.

I will build it as part of my next build, and try it out, style problems or no. :)

total: 158 errors, 362 warnings, 21 checks, 746 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

0001-Attempt-to-build-pie.patch has style problems, please review.

See also: https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt

gautamramk commented 5 years ago

Thanks a lot, I shall immediately get working on fixing the coding style.