search

gauteh / lieer

Fast email-fetching and sending and two-way tag synchronization between notmuch and GMail
http://lieer.gaute.vetsj.com
Other
494 stars 60 forks source link

Use Loopback IP address auth flow instead of deprecated OOB #231

Closed skangas closed 1 year ago

skangas commented 1 year ago

This should fix the authorization flow, as discussed in #215. @tohojo already did all the heavy lifting and wrote up a patch, so I just tested that it works and made this pull request.

I would have actually preferred to put the commit in Toke's name, but I didn't want to do so without his consent. Instead, I acknowledge him in a Co-authored-by tag in the commit message. If Toke prefers, I'm obviously happy to make him the author instead. (My own changes were minimal.)

The patch works here, but more testing is obviously welcome.

For reference, see: https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html https://developers.google.com/identity/protocols/oauth2/resources/oob-migration

gauteh commented 1 year ago

Great! @tohojo do you wish to be Author: ?

tohojo commented 1 year ago

I'm okay with co-authored-by; thanks for turning this into a proper PR! :)

gauteh commented 1 year ago

Thanks, merged. Maybe instructions need to be updated as well? Does this close the auth issue?

skangas commented 1 year ago

Thanks, merged. Maybe instructions need to be updated as well? Does this close the auth issue?

I believe it does, or at least everything is now working on my end. I took a look at the README and everything there looks good to me from a cursory look.

gauteh commented 1 year ago

Great!

lør. 31. des. 2022, 15:36 skrev Stefan Kangas @.***>:

Thanks, merged. Maybe instructions need to be updated as well? Does this close the auth issue?

I believe it does, or at least everything is now working on my end. I took a look at the README and everything there looks good to me from a cursory look.

— Reply to this email directly, view it on GitHub https://github.com/gauteh/lieer/pull/231#issuecomment-1368223614, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAN36377VYE3OWHIEERQ5LWQBAFBANCNFSM6AAAAAATNRA7MY . You are receiving this because you modified the open/close state.Message ID: @.***>