soc-se-bot
commented
2 months ago Team's Response
Feature not a bug.
Its not case sensitive but it also does not reject persons as duplicates even with the same case format, we just simply allow different people with the same name as previously mentioned. Can multiple people in the same online clan have the same name? obviously yes.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Allowing adding of the same person
[original: nus-cs2103-AY2324S2/pe-interim#78] [original labels: severity.Low type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
It was explicitly stated in the UG that people with the same name is not considered a duplicate, evene if they have the same tags and categories and descriptions. This was an explicit design choice for user freedom due to the fact that there can easily characters with the same name in multiple games or in the same game. Many people in real life also have the same name, and rarely give their full name to other fellow gamers for their contact, so many gamers may only know each other by first name basis.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** _"It was explicitly stated in the UG that people with the same name is not considered a duplicate, even if they have the same tags and categories and descriptions."_ _Can multiple people in the same online clan have the same name? obviously yes._ If the name, tags, categories and descriptions are all the same and still allowed, it can potentially cause a lot of confusion of the user at some point in time. In a previous issue, they mentioned that the users can use their creative freedom to identify between different contacts with similar information. The same thing can be applied here, if multiple people in the same online clan have the same name, the user should use their creative freedom to identify them through other means eg. tags, and not just allow the app to add in duplicate users with identical information. What I think they should have done is to not allow people with identical information (name, tag, clan, description) to be added into the addressbook because it can cause issues if the user adds a duplicate person unintentionally. Furthermore, to identify between multiple people in the same online clan having the same name, the user can use their creative freedom to add unique tags when performing the add command to add them into the addressbook. Using this suggestion, the addressbook can check for duplicates and the user can also add multiple people with the same name using their creativity.
In the real world, names are not case sensitive. So in this example, both of these players should refer to the same person and should be checked for, if not there will be duplicated persons in the same clan.