gavin971 / cvmix

Automatically exported from code.google.com/p/cvmix
0 stars 0 forks source link

cvmix_put routines are incomplete #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Two related issues:

1) cvmix_put_int writes an integer value into real(cvmix_r8) variables. We 
should explicitly set them to real(val, cvmix_r8).

2) It looks like not all the variables in cvmix_data_type are handled by all 
the different implementations of cvmix_put. For example, cvmix_put_int accepts 
nlev (scalar int), diff (1d real), and visc (1d real), while cvmix_put_real 
accepts diff, visc, ocean bottom (scalar real), and depth (scalar real). There 
are other 1d reals, though I don't know if we want to support setting them to a 
constant value: layer depth (interface and midpoint), layer thickness (top to 
bottom as well as midpoint to midpoint), Richardson number, buoyancy, and 
density.

Original issue reported on code.google.com by mike.lev...@gmail.com on 6 Jun 2013 at 5:55

GoogleCodeExporter commented 9 years ago
Between r158 and r159, this issue has been taken care of. As noted in the r159 
commit log, though, it's spawned another issue regarding error checking...

Original comment by mike.lev...@gmail.com on 7 Jun 2013 at 10:58