search

gavinbunney / terraform-provider-bitbucketserver

Terraform provider for Bitbucket Server Management
https://registry.terraform.io/providers/gavinbunney/bitbucketserver/latest
Mozilla Public License 2.0
29 stars 33 forks source link

Add Exists method for resource defaultReviewersCondition #21

Closed Kamahl19 closed 4 years ago

Kamahl19 commented 4 years ago

When somebody removed condition via UI and then wants to recreate it, its not possible unless doing terraform state rm... This fixes this issue and also fixes the case when somebody changes the condition via UI manually

Kamahl19 commented 4 years ago

@gavinbunney Hey, sorry to bother you again. Would you be able to merge and release this one as well? It finally fixes the resource for all cases

codecov-commenter commented 4 years ago

Codecov Report

Merging #21 into master will decrease coverage by 0.22%. The diff coverage is 60.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   84.59%   84.37%   -0.23%     
==========================================
  Files          37       37              
  Lines        3292     3315      +23     
==========================================
+ Hits         2785     2797      +12     
- Misses        295      301       +6     
- Partials      212      217       +5
Impacted Files Coverage Δ
bitbucket/resource_default_reviewers_condition.go 79.90% <60.60%> (-3.53%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1c2e29...534d71d. Read the comment docs.