Closed ccrockatt closed 4 years ago
I believe this PR should be split to multiple smaller PRs each taking care of it's own thing. It's never good to merge stuff like this, its hard to reason about multiple different changes and hard to revert them if one of them is problematic
I have updated README.md in this PR which includes some of your changes and adds others to make development and testing instructions clear and simple https://github.com/gavinbunney/terraform-provider-bitbucketserver/pull/13
I believe this PR should be split to multiple smaller PRs each taking care of it's own thing. It's never good to merge stuff like this, its hard to reason about multiple different changes and hard to revert them if one of them is problematic
We included all the changes that we made in order to get the functionality working.
I have updated README.md in this PR which includes some of your changes and adds others to make development and testing instructions clear and simple #13
We've reverted the changes to the Readme.md
Merging #8 into master will increase coverage by
0.17%
. The diff coverage is88.23%
.
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 85.26% 85.43% +0.17%
==========================================
Files 35 37 +2
Lines 3284 3529 +245
==========================================
+ Hits 2800 3015 +215
- Misses 283 300 +17
- Partials 201 214 +13
Impacted Files | Coverage Δ | |
---|---|---|
bitbucket/resource_group.go | 91.22% <88.23%> (+3.13%) |
:arrow_up: |
bitbucket/data_user.go | 100.00% <0.00%> (ø) |
|
bitbucket/resource_default_reviewers_condition.go | 83.74% <0.00%> (ø) |
|
bitbucket/provider.go | 97.26% <0.00%> (+0.07%) |
:arrow_up: |
bitbucket/resource_user.go | 86.04% <0.00%> (+0.10%) |
:arrow_up: |
bitbucket/client.go | 67.05% <0.00%> (+3.52%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f116e39...a38a9f4. Read the comment docs.
@gavinbunney Can you please take another look and see if we're ready to merge the PR? Please let us know if you have more questions or concerns. Thanks.
Added a flag to specify whether to import groups that already exist in bitbucket along with functionality to import those groups into the terraform state
Changed the error checking when importing an existing group for bitbucket so that the duplicate group error is not thrown
Added two acceptance tests
Updated the ReadMe.md with accurate instructions since the previous ones were not working for us
Updated the Makefile to set the maximum number of files allowed to be open to 1024 since 256 was too few. We called
ulimit -n 1024
to do this for the testacc and testacc-bitbucket targets.Changed the start-docker-compose.sh to use the bitbucket server environment variable so that it doesn't always refer to localhost
Skipped some testcases that are consistently failing in master branch
Added a version.env file to be used to control the versioning from CICD builds
Set version to 1.4.0