gavinbunney / terraform-provider-bitbucketserver

Terraform provider for Bitbucket Server Management
https://registry.terraform.io/providers/gavinbunney/bitbucketserver/latest
Mozilla Public License 2.0
29 stars 33 forks source link

Import existing groups #8

Closed ccrockatt closed 4 years ago

ccrockatt commented 4 years ago
Kamahl19 commented 4 years ago

I believe this PR should be split to multiple smaller PRs each taking care of it's own thing. It's never good to merge stuff like this, its hard to reason about multiple different changes and hard to revert them if one of them is problematic

Kamahl19 commented 4 years ago

I have updated README.md in this PR which includes some of your changes and adds others to make development and testing instructions clear and simple https://github.com/gavinbunney/terraform-provider-bitbucketserver/pull/13

ccrockatt commented 4 years ago

I believe this PR should be split to multiple smaller PRs each taking care of it's own thing. It's never good to merge stuff like this, its hard to reason about multiple different changes and hard to revert them if one of them is problematic

We included all the changes that we made in order to get the functionality working.

ccrockatt commented 4 years ago

I have updated README.md in this PR which includes some of your changes and adds others to make development and testing instructions clear and simple #13

We've reverted the changes to the Readme.md

codecov-commenter commented 4 years ago

Codecov Report

Merging #8 into master will increase coverage by 0.17%. The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   85.26%   85.43%   +0.17%     
==========================================
  Files          35       37       +2     
  Lines        3284     3529     +245     
==========================================
+ Hits         2800     3015     +215     
- Misses        283      300      +17     
- Partials      201      214      +13     
Impacted Files Coverage Δ
bitbucket/resource_group.go 91.22% <88.23%> (+3.13%) :arrow_up:
bitbucket/data_user.go 100.00% <0.00%> (ø)
bitbucket/resource_default_reviewers_condition.go 83.74% <0.00%> (ø)
bitbucket/provider.go 97.26% <0.00%> (+0.07%) :arrow_up:
bitbucket/resource_user.go 86.04% <0.00%> (+0.10%) :arrow_up:
bitbucket/client.go 67.05% <0.00%> (+3.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f116e39...a38a9f4. Read the comment docs.

eli-guidewire commented 4 years ago

@gavinbunney Can you please take another look and see if we're ready to merge the PR? Please let us know if you have more questions or concerns. Thanks.