gavincarr / mod_auth_tkt

Lightweight single-signon authentication module for Apache

Other

37 stars 22 forks source link

Apache 2.4 #12

Closed karpet closed 9 years ago

karpet commented 10 years ago

This compiles and seems to pass its tests. There are still several non-fatal compile-time warnings.

vladsf commented 10 years ago

I think this patch ignores APACHE22 usage in the code. The patch used in mod_auth_tkt Debian package for apache 2.4 looks better.

vladsf commented 10 years ago

The link on the debian package https://packages.debian.org/source/sid/libapache2-mod-auth-tkt

pkarman commented 10 years ago

Good to know Debian solved the problem too.

I notice Debian does not patch configure which suggests that the previous way of identifying version via compile-time definition is no longer used. No judgement on that; just an observation.

gavincarr commented 9 years ago

Hi Peter,

Thanks for your patches, incorporated into the 2.3.99b1 beta.

Cheers, Gavin

vladsf commented 9 years ago

I don't understand how this patch would not break other code chunks with

ifndef APACHE22

...

else

clearly the build will be broken with only -DAPACHE24

Debian patch uses proper, universal call to identify which Apache version is used: +#if AP_MODULE_MAGIC_AT_LEAST(20111130,0)

gavincarr commented 9 years ago

There were 3 sets of patches out there - Peter's, Ivo's/debian's, and Dietmar's. The 2.4 changes are are a blend of all 3, and do use AP_MODULE_MAGIC_AT_LEAST (check the code).

Cheers, Gavin

vladsf commented 9 years ago

ah, I see now. good!