search

gavincarr / mod_auth_tkt

Lightweight single-signon authentication module for Apache
Other
37 stars 22 forks source link

Copy Host header before modifying in get_domain() #15

Open mocmocamoc opened 9 years ago

mocmocamoc commented 9 years ago

At the moment get_domain() will strip the port number from the original Host header, meaning that subsequent functions that use the header will find it missing the port number. For example, redirect() calls get_domain() before itself retrieving the Host header, so the port number will always be gone before redirect() can get it.

ronisaacson commented 5 years ago

This is a valid issue, but a better fix is:

domain = apr_pstrdup(r->pool, domain);