gavingoh99 / pe

0 stars 0 forks source link

Mandarin client names are not accepted #3

Open gavingoh99 opened 6 months ago

gavingoh99 commented 6 months ago

Given that SWEE is intended for tracking of contacts and their associated information, there could be an instance of a contact who only has a name in Mandarin. In such a case, however, SWEE does not accept the name which could result in difficulty on the user end to store their contacts since the older generation are unlikely to have english names as an alternative.

Steps to reproduce:

  1. add --name=小明 --phone=98001715 --email=theodore@example.com --addr=Prince Street, Block 144, #19-14 --tags=Disabled --note=Lactose Intolerant

Resultant output:

Screenshot 2024-04-19 at 4.40.05 PM.png

To alleviate this, I would suggest planning a future enhancement that could allow this!

soc-pe-bot commented 6 months ago

Team's Response

As stated clearly in our user guide, only alphanumeric characters are accepted as client names.

In your example, 小明 could simply be saved as Xiao Ming.

This is not a bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hello and thanks for the response!

I understand that the UG as well as the application specify that name can only consist of alphanumeric characters. This motivated my decision to report this as a FeatureFlaw.

From my perspective, I felt that the inability to allow for names in other languages like Mandarin can severely affect the user's ability to add contacts whose names are provided in the given language, thus making the feature feel 'incomplete' in that sense.

Furthermore, if we consider the workaround provided in your team's response, there might still be ambiguities which SWEE cannot resolve.

There could be two clients called 小明 and 晓明 both of which are translated to Xiao Ming according to the workaround provided. However, since SWEE does not support duplicate names, this adds to the difficulty experienced by the user in attempting to add both contacts.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** As mentioned earlier, the current implementation doesn't allow for Mandarin names and the workaround does not fully alleviate this if we consider the scenario provided above. In the worst case, users with a large proportion of clients possessing only Mandarin names will face immense difficulty in integrating their contacts and fully utilising the application. If we zoom in to the context of Singapore, a large proportion of social workers for instance interact with those belonging to the older generation who might legitimately only possess Mandarin names. Under such circumstances, the supposed 'incompleteness' of the feature is on full display as the application would not be able to provide the functionality required of it in this context!