gavingoh99 / pe

0 stars 0 forks source link

Unable to search by note #7

Open gavingoh99 opened 4 months ago

gavingoh99 commented 4 months ago

In SWEE, notes appear to be allow users an additional field for documenting certain comments or remarks about clients.

It would therefore seem intuitive to have a means of searching by these notes.

For instance, a user recalls working with a client who has a dog and wishes to contact them. However, other than that description, they do not recall other details like what they had previously tagged them with or their name.

Unable to search by notes, the user would in turn have to scroll through the application manually to look for the note for visual confirmation, thus adding to the time taken to retrieve the relevant information.

Steps to reproduce:

  1. edit 1 --note=Has a cute dog
  2. User wishes to search by note but SWEE does not have a function or command to do so
nus-pe-script commented 4 months ago

Team's Response

This is not a bug / issue.

We do not see the need for this command to be implemented, hence we did not plan for it.

A simple work-around could be to tag this client as 'HasADog', and find-tag instead.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for providing a workaround for this!

It does, however, imply the redundancy of having a notes field for each client. If we were to abide by the suggested workaround in order to search by tag, then it is likely that there is no need for the notes field at all!

In a sense, my reporting of this issue as a FeatureFlaw was motivated by the general feeling that the notes field was not sufficiently integrated into the application. I felt that this was evident in the lack of a search-by-note command. In a sense, the notes field appears to only be helpful when the user is able to successfully navigate to the client to begin with! To re-hash my point, as humans tend to remember features of the people they meet rather than their names, there is a legitimate use for searching by remarks about them. Therefore, without such a feature, the introduction of a notes field felt 'incomplete'.

Furthermore, the team's response and suggestion of using tags instead seems to further my point. If information that should have been stored as remarks under the notes field can be stored in the tags - then what should we store in the notes field?


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Again, `severity.VeryLow` implies a cosmetic issue at best. Following my above argument, given that the notes field is introduced as a means of storing additional information, it is likely that there will be users who wish to look up clients based on this! The lack of such a feature appears to add extra inconvenience in looking up a client that a user may not remember the name or tags of. If we were to follow the workaround, the issue is exacerbated because the purpose of the notes field is called into question - if tags can do everything that a note can do, then the note field for clients can be seen as an 'incomplete' or unpolished feature since its purpose can be fulfilled by an existing feature.