search

gavinhoward / bc

An implementation of the POSIX bc calculator with GNU extensions and dc, moved away from GitHub. Finished, but well-maintained.
https://git.gavinhoward.com/gavin/bc
Other
162 stars 32 forks source link

Test should use the file name created if the file is not found #12

Closed stesser closed 5 years ago

stesser commented 5 years ago

If $destdir is set, the test did not check the existence of the file that was required for the symlink operation (and created by the conditional gencat). That lead to the file being re-created if not found at the location of the final destination (ignoring $destdir), even though it existed at $destdir/$linksrc.

codecov[bot] commented 5 years ago

Codecov Report

Merging #12 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #12   +/-   ##
======================================
  Coverage    99.9%   99.9%           
======================================
  Files          16      16           
  Lines        3089    3089           
======================================
  Hits         3086    3086           
  Misses          3       3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08727ac...d9bda13. Read the comment docs.

gavinhoward commented 5 years ago

@stesser once again, you have a better eye than I do. Thank you very much!

Merged.