jprjr commented 5 years ago

Just some minor tweaks - I noticed the symlinks were being generated with "./" in them, which isn't necessary.

I also switch install.sh to use readlink to resolve symlinks, instead of parsing the output of ls. Both methods are support by POSIX, I just think readlink makes it more apparent what's going on.

codecov[bot] commented 5 years ago

Codecov Report

Merging #5 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files          16       16           
  Lines        2876     2876           
=======================================
  Hits         2817     2817           
  Misses         59       59

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dbbe325...18e3639. Read the comment docs.

gavinhoward commented 5 years ago

Merged. Will make a few changes, but thank you for your contribution!

Also, I am investigating the readlink item more. I may keep that change too; I just have to see what is truly portable across POSIX.

gavinhoward / bc

avoid ./ in symlink paths, use readlink instead of ls to resolve link #5

Codecov Report