gavinljj / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

ARGBToNV12 leaks row_u_mem #352

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
ARGBToNV12 in the early return leaks the row_u_mem ( if (!src_argb ||
      !dst_y || !dst_uv ||
      width <= 0 || height == 0) {
    return -1;
  })

Original issue reported on code.google.com by fbarch...@google.com on 20 Aug 2014 at 9:50

GoogleCodeExporter commented 9 years ago
after fixing that one, there still seem to be more

~~Dr.M~~ ERRORS IGNORED:
~~Dr.M~~      10 potential leak(s) (suspected false positives)
~~Dr.M~~          (details: C:\Users\fbarchard\AppData\Roaming\Dr. 
Memory\DrMemory-libyuv_unittest.exe.8620.000\potential_errors.txt)
~~Dr.M~~       8 unique,    87 total,  10665 byte(s) of still-reachable 
allocation(s)
~~Dr.M~~          (re-run with "-show_reachable" for details)
~~Dr.M~~ Details: C:\Users\fbarchard\AppData\Roaming\Dr. 
Memory\DrMemory-libyuv_unittest.exe.8620.000\results.txt
~~Dr.M~~ WARNING: application exited with abnormal code 0x1

Original comment by fbarch...@google.com on 21 Aug 2014 at 9:57

GoogleCodeExporter commented 9 years ago
ARGBToNV12 and NV21 fixed in r1057

This is a better indication of leaks:

ERRORS FOUND:
      4 unique,     4 total,   4348 byte(s) of leak(s)

Original comment by fbarch...@google.com on 21 Aug 2014 at 10:46

GoogleCodeExporter commented 9 years ago
r1059 fixes all conversion leaks.

Original comment by fbarch...@google.com on 22 Aug 2014 at 5:21

GoogleCodeExporter commented 9 years ago

Original comment by fbarch...@google.com on 22 Aug 2014 at 9:53