gavinlyonsrepo / TM1638plus

An Arduino library to drive TM1638 seven segment modules.
https://gavinlyonsrepo.github.io/
GNU General Public License v3.0
79 stars 25 forks source link

Right align numbers when using displayIntNum and DisplayDecNumNibble #17

Closed adite closed 2 years ago

adite commented 2 years ago

displayIntNum / DisplayDecNumNibble with leadingZeros = false prints numbers left aligned. I guess they should be printed right aligned, like leadingZeros = true does.

gavinlyonsrepo commented 2 years ago

Hi

That's the way it was supposed to be, "Numbers left aligned with leading zeros optional." Its working as designed, not a bug. I suppose the user should have an option for all three , left aligned, right aligned, and right aligned with leading zeros. I will put this in at next update, No plans for update at the moment, so it might be a while.

regards

adite commented 2 years ago

Hi,

Thank you. I agree with you that the user should have all 3 choices. But for my needings the left aligned decimal number is not very useful. I will close the PR.

Regards, Adrian

gavinlyonsrepo commented 1 year ago

This is now implemented in Version 1.9.0