gavinmn / logseq-luma

A minimal and detail oriented light and dark theme for Logseq
MIT License
107 stars 11 forks source link

Bullet for H3 headers not aligned #1

Closed martindufort closed 2 years ago

martindufort commented 2 years ago

The bullet for H3 header is not center-aligned with the text. Is this by design?

CleanShot 2022-07-28 at 09 17 34
gavinmn commented 2 years ago

Not by design, but I haven't found a workaround yet for adjusting this when the font size is made smaller.

eryc-cc commented 2 years ago

Here's a quick workaround that I found.

https://github.com/logseq/logseq/issues/4261#issuecomment-1198945742

If you're looking for a quick fix, you can add the following code to your custom.css:

:not(.block-ref) .ls-block h1,
:not(.block-ref) .ls-block h2,
:not(.block-ref) .ls-block h3,
:not(.block-ref) .ls-block h4,
:not(.block-ref) .ls-block h5,
:not(.block-ref) .ls-block h6 {
  transform: translateY(-4px);
}

The reason why I'm using translateY(-4px) is because the div that wraps both the bullet with the text aligns them in the baseline. For some reason, when you decrease the size of the headings, it doesn't align properly.

Maybe it's because they're setting a fixed height? I didn't debug it enough...

Here's the screenshot of a <h3> tag. I changed the font-size to 1.125rem, here's what it looks like when I inspect:

Without translateY:

Screen Shot 2022-07-29 at 3 56 30 AM Screen Shot 2022-07-29 at 3 58 48 AM Screen Shot 2022-07-29 at 3 57 17 AM Screen Shot 2022-07-29 at 3 57 33 AM

With translateY:

Screen Shot 2022-07-29 at 3 59 18 AM Screen Shot 2022-07-29 at 3 47 25 AM Screen Shot 2022-07-29 at 3 47 39 AM Screen Shot 2022-07-29 at 3 47 57 AM

I like to have my headings a little bit smaller than the default option, here's the code for it (it's working quite nicely with the translate change):

/* Content Headings */
.editor-inner .h1.uniline-block, :not(.block-ref) .ls-block h1 { 
  font-size: 1.675rem; 
}
.editor-inner .h2.uniline-block, :not(.block-ref) .ls-block h2 { 
  font-size: 1.375rem; 
}
.editor-inner .h3.uniline-block, :not(.block-ref) .ls-block h3 { 
  font-size: 1.125rem; 
}
.editor-inner .h4.uniline-block, :not(.block-ref) .ls-block h4 { 
  font-size: 1rem; 
}
.editor-inner .h5.uniline-block, :not(.block-ref) .ls-block h5 { 
  font-size: .875rem; 
}
.editor-inner .h6.uniline-block, :not(.block-ref) .ls-block h6 { 
  font-size: .75rem; 
}
gavinmn commented 2 years ago

Here's a quick workaround that I found

Thanks! I'll get this added

eryc-cc commented 2 years ago

@gavinmn Mind if I create a PR? 👀

gavinmn commented 2 years ago

@gavinmn Mind if I create a PR? 👀

Sure! I'd appreciate it.