gavinpugh / vs-android

Integrated development of Android NDK C/C++ software with Microsoft Visual Studio.
Other
119 stars 34 forks source link

Incorrect read.1.tlog file genearted #130

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. In a project edit a .h file so that it won't compile.
2. Build the project.
3. .cpp files that hit the compile error will still be added to the read.1.tlog 
compiler dependencies file.
4. Fix the compile error in the .h file.
5. NOTE: the .cpp files that should be re-built will now never be built again 
until you perform a clean.

What is the expected output? What do you see instead?

It is expected that the dependencies are tracked properly always, even in cases 
of compile errors.  This isn't the case, an empty list of .h dependencies is 
written in the read.1.tlog file in-case of compile errors.  This breaks all 
future builds until you clean the project.

What version of the product are you using? On what operating system?

0.963 on VS2013 Windows 8.

Please provide any additional information below.

I have attached a patch fix for the issue.  GCCCompile.cs
This fix is to only write out the info to the .read.1.tlog file if the 
objectFile was generated, and the .d dependency file was read in properly.

Original issue reported on code.google.com by d...@thedunlops.ca on 19 Nov 2014 at 12:02

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by gavin.dj.pugh on 10 Dec 2014 at 5:41

GoogleCodeExporter commented 9 years ago
Thanks for the fix!

Integrated into the v0.964 release that was uploaded today.

Original comment by gavin.dj.pugh on 29 Dec 2014 at 7:18