search

gavinsimpson / gratia

ggplot-based graphics and useful functions for GAMs fitted using the mgcv package
https://gavinsimpson.github.io/gratia/
Other
206 stars 28 forks source link

aes_string and aes_ may be deprecated in the future are aren't recommended any longer #159

Closed gavinsimpson closed 2 years ago

gavinsimpson commented 2 years ago

{gratia} makes extensive use of aes_string() and aes_() to build mappings for ggplot(). Seems like these may go away and are no longer recommended: https://ggplot2.tidyverse.org/articles/ggplot2-in-packages.html

So fix up all instances to a new idiom as indicated on that page

hammadsheikh commented 2 years ago

Hey Gavin. I am just starting to contribute to packages I like. If no one else is working on this issue, I would love to offer my help to fix up all instances of aesstring() and aes(). Feel free to assign this issue to me.

gavinsimpson commented 2 years ago

Thanks for the offer @hammadsheikh! I'd already sat down and tackled most of this at the weekend

hammadsheikh commented 2 years ago

Really appreciate your project. Will have an eye out for other issues I can help you with in the future.