gavinsimpson / gratia

ggplot-based graphics and useful functions for GAMs fitted using the mgcv package
https://gavinsimpson.github.io/gratia/
Other
206 stars 28 forks source link

Break everything with name changes #247

Closed gavinsimpson closed 10 months ago

gavinsimpson commented 10 months ago

All of {gratia}'s functions are going through a process of consistency improvement. I want functions to feel like they work in a similar way and output objects in consistent way. This is an ongoing process but it is going to break things... Sorry!

The key thing that I'm doing is changing names of generated columns so that instead of having a name of the form "foo", they will now have a name of the form ".foo". This affects the main user-facing functions smooth_estimates(), derivatives(), etc. It will likely only affect functions that mix derived/generated columns with user data. It makes less sense to prefix all column names with a . for functions that don't mix generated and user data columns.

This might change if I find it more consistent to preface everything.

Functions to change:

gavinsimpson commented 10 months ago

Closing as I think I have done everything now. Will reopen if I notice things as I start to prep the package for release and do the polishing.