gavioto / m2e-extensions

Automatically exported from code.google.com/p/m2e-extensions
0 stars 0 forks source link

Incorrect use of URIUtils.resolve? #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi there,

I think the PMD extension has a brain hiccup in it:

maven/ide/plugins/org.maven.ide.eclipse.extensions.project.configurators.pmd/src
/main/java/org/maven/ide/eclipse/extensions/project/configurators/pmd/MavenPlugi
nConfigurationTranslator.java
--- 
a/maven/ide/plugins/org.maven.ide.eclipse.extensions.project.configurators.pmd/s
rc/main/java/org/maven/ide/eclipse/extensions/project/configurators/pmd/MavenPlu
ginConfigurationTranslator.java Sun Mar 21 19:34:51 2010 -0500
+++ 
b/maven/ide/plugins/org.maven.ide.eclipse.extensions.project.configurators.pmd/s
rc/main/java/org/maven/ide/eclipse/extensions/project/configurators/pmd/MavenPlu
ginConfigurationTranslator.java Tue Sep 21 17:24:16 2010 -0700
@@ -219,7 +219,7 @@
         final List<String> folders = new ArrayList<String>();
         //No null check as internally we *know*
         for (File f: sources) {
-            String relativePath = URIUtils.resolve(f.toURI(), 
this.basedirUri).getPath();
+            String relativePath = 
URIUtils.resolve(this.basedirUri,f.toURI()).getPath();

----

basedirUri should be the first argument to URIUtils.resolve

Original issue reported on code.google.com by jatw...@linuxstuff.org on 22 Sep 2010 at 12:36

GoogleCodeExporter commented 9 years ago
thanks for the patch

Original comment by mkann...@gmail.com on 28 Sep 2010 at 11:23

GoogleCodeExporter commented 9 years ago
resolved as of f0453cdde3

Original comment by mr.id...@gmail.com on 20 Dec 2010 at 5:15