gavioto / playn

Automatically exported from code.google.com/p/playn
0 stars 0 forks source link

TypedArrays gwt.xml in playn/webgl blows away the real TypedArrays in gwt 2.5 #210

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Put playn-webgl jar above gwt-2.5 in classpath.
2. Reference both webgl code and typed array code in EntryPoint.
3. Try to compile.

Error message:
[ERROR] Errors in 
'jar:file:/home/x/.../gwt-2.5.0.rc1/gwt-user.jar!/com/google/gwt/xhr/client/XMLH
ttpRequest.java'
      [ERROR] Line 219: No source code is available for type com.google.gwt.typedarrays.shared.ArrayBuffer; did you forget to inherit a required module?

The problem is, both jars use the same module xml to import TypedArrays, but 
the playn version only pulls in the client source folder, while gwt needs both 
client and shared:

http://code.google.com/p/playn/source/browse/webgl/src/com/google/gwt/typedarray
s/TypedArrays.gwt.xml

Whereas the gwt version does some extra leg work:

http://code.google.com/p/google-web-toolkit/source/browse/trunk/user/src/com/goo
gle/gwt/typedarrays/TypedArrays.gwt.xml

Workaround:

Put playn-webgl below gwt sdk on classpath.

Fixes:

1) Change playn-webgl's c.g.g.typedarrays.TypedArrays.gwt.xml file name so both 
can peacefully coexist. (best)
2) Copy the module xml from gwt (it has deferred binding rules, so maybe not 
wise to fork)
3) Eventually delete the playn copy and just require gwt.v > 2.5 (superdevmode 
is worth upgrading for anyway).

Original issue reported on code.google.com by Ja...@wetheinter.net on 22 Aug 2012 at 2:33

GoogleCodeExporter commented 9 years ago
Should be fixed now that we use GWT's TypedArrays.

Original comment by m...@samskivert.com on 29 Nov 2012 at 12:38

GoogleCodeExporter commented 9 years ago
Awesome, thanks (for this and all the other hard work).

Is it only in 1.6-SNAPSHOT, or in 1.5 from central?

Original comment by Ja...@wetheinter.net on 29 Nov 2012 at 1:06

GoogleCodeExporter commented 9 years ago
It's in 1.5 (and 1.5.1).

Original comment by m...@samskivert.com on 29 Nov 2012 at 4:30