search

gavioto / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Pressing during reviewer email lookup results in sending an email #316

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
If I add someone's name to the reviewers list, a spinning "progress" icon will 
be shown while rietveld attempts to look up that person. Eventually, it will 
show a drop-down menu with various matches.

While my focus is still in the reviewers or CC field and the icon is spinning, 
but the popup menu is not yet up, if I press enter, it acts as "submit" and 
sends the email out.

If I press enter after the popup menu has already appeared, it chooses the 
first entry from the popup menu and doesn't submit.

This inconsistency has resulted in me sending out a mail prematurely several 
times, when I hit enter before the popup menu is up.

Pressing enter after typing someone's name in the reviewers list but before it 
has had a chance to bring up the popup should not submit the form and send the 
email out - when my intention was to just choose the first entry from the 
drop-down list but I was too trigger happy..

Original issue reported on code.google.com by asvitkine@chromium.org on 17 Jun 2011 at 2:22

GoogleCodeExporter commented 9 years ago 
We use version 1.0.3 of autocomplete plugin from 
http://bassistance.de/jquery-plugins/jquery-plugin-autocomplete/ - if you 
believe that upgrading to a newer version will fix the issue, we may attempt to 
do this.

Original comment by techtonik@gmail.com on 19 Jun 2011 at 10:40

GoogleCodeExporter commented 9 years ago 
Pardon, the version is 1.0.2 and here is the changelog of all changes for this 
plug - http://jquery.bassistance.de/autocomplete/changelog.txt

Original comment by techtonik@gmail.com on 19 Jun 2011 at 10:42

GoogleCodeExporter commented 9 years ago 
I don't see anything about this issue in the changelog.txt.

The first page linked to starts with "This plugin is deprecated and not 
developed anymore." :(

Original comment by asvitkine@chromium.org on 20 Jun 2011 at 7:51

GoogleCodeExporter commented 9 years ago 
As far as I know we don't have any heavy dependencies on jQuery except this 
plug, so it should be pretty easy to move to jQuery + jQuery UI, but me 
personally doesn't have experience with UI part and I can't say when I'll be 
able to look at it.

Original comment by techtonik@gmail.com on 20 Jun 2011 at 8:21

GoogleCodeExporter commented 9 years ago 
AFAIK it's the only JQuery dependency we have and I wouldn't be too sad if we 
could remove it, so that we don't need to load JQuery at all. But of it's just 
a "return false" somewhere to stop event propagation to solve this issue we 
should add it. - but I've had no time for a closer look yet...

Original comment by albrecht.andi on 20 Jun 2011 at 8:29

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 7:25