gavioto / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

gcl Crashes on Upload After Deleting the Corresponding Issue #449

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. gcl upload a changelist
2. Delete the corresponding issue on https://codereview.chromium.org/
3. gcl upload that same changelist

What is the expected output?
A changelist uploaded with a new issue

What do you see instead?
Stack trace crash (see below)

What browser are you using?  What version? On what operating system?
Chrome 27, Windows

At what URL are you accessing Rietveld?  (e.g. codereview.appspot.com)
Please note if you are using the Google Apps Labs version (e.g.
codereview.<yourdomain>).

*** If you are a Google employee please say so or mail rietveld-admins@
directly. ***

Please provide any additional information below.
The workaround is to reset the issue info in gcl\changes\[changelist]

Stack trace:
Traceback (most recent call last):
  File "D:\depot_tools\gcl.py", line 1476, in <module>
    sys.exit(main(sys.argv[1:]))
  File "D:\depot_tools\gcl.py", line 1454, in main
    return command(argv[1:])
  File "D:\depot_tools\gcl.py", line 769, in hook
    return function(change_info, args)
  File "D:\depot_tools\gcl.py", line 821, in CMDupload
    output = OptionallyDoPresubmitChecks(change_info, False, args)
  File "D:\depot_tools\gcl.py", line 738, in OptionallyDoPresubmitChecks
    return DoPresubmitChecks(change_info, committing, True)
  File "D:\depot_tools\gcl.py", line 1237, in DoPresubmitChecks
    rietveld_obj=change_info.RpcServer())
  File "D:\depot_tools\presubmit_support.py", line 1180, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "D:\depot_tools\presubmit_support.py", line 1097, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 972, in CheckChangeOnUpload
  File "<string>", line 807, in _CommonChecks
  File "D:\depot_tools\presubmit_canned_checks.py", line 988, in PanProjectChecks
    input_api, output_api, source_file_filter=None))
  File "D:\depot_tools\presubmit_canned_checks.py", line 808, in CheckOwners
    approval_needed=input_api.is_committing)
  File "D:\depot_tools\presubmit_canned_checks.py", line 848, in _RietveldOwnerAndReviewers
    issue_props = _GetRietveldIssueProps(input_api, True)
  File "D:\depot_tools\presubmit_canned_checks.py", line 839, in _GetRietveldIssueProps
    issue=int(issue), messages=messages)
  File "D:\depot_tools\rietveld.py", line 444, in get_issue_properties
    super(CachingRietveld, self).get_issue_properties)
  File "D:\depot_tools\rietveld.py", line 423, in _lookup
    function_cache[args] = update(*args)
  File "D:\depot_tools\rietveld.py", line 96, in get_issue_properties
    data = json.loads(self.get(url))
  File "D:\depot_tools\rietveld.py", line 357, in get
    return self._send(request_path, **kwargs)
  File "D:\depot_tools\rietveld.py", line 383, in _send
    result = self.rpc_server.Send(request_path, **kwargs)
  File "D:\depot_tools\third_party\upload.py", line 439, in Send
    f = self.opener.open(req)
  File "D:\depot_tools\python_bin\lib\urllib2.py", line 389, in open
    response = meth(req, response)
  File "D:\depot_tools\python_bin\lib\urllib2.py", line 502, in http_response
    'http', request, response, code, msg, hdrs)
  File "D:\depot_tools\python_bin\lib\urllib2.py", line 427, in error
    return self._call_chain(*args)
  File "D:\depot_tools\python_bin\lib\urllib2.py", line 361, in _call_chain
    result = func(*args)
  File "D:\depot_tools\python_bin\lib\urllib2.py", line 510, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 404: Not Found
Sending crash report ...
  args: ['D:\\depot_tools\\gcl.py', 'upload', 'f7z1']
  cwd: D:\src
  exception: HTTP Error 404: Not Found

Original issue reported on code.google.com by robl...@chromium.org on 7 Jun 2013 at 12:23

GoogleCodeExporter commented 9 years ago
gcl is not a rietveld tool but a chromium tool. Please file a report at 
http://crbug.com/new so it can be triaged accordingly.

Original comment by maruel@chromium.org on 7 Jun 2013 at 1:02