gavioto / stexbar

Automatically exported from code.google.com/p/stexbar
0 stars 1 forks source link

tabspace: allow exluding files and/or masks #187

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
instead of only an include pattern, also allow an exclude pattern.

Original issue reported on code.google.com by tortoisesvn on 22 Apr 2012 at 7:03

GoogleCodeExporter commented 9 years ago
Hi Stephan. Could you please implement this? It's very trivial and it will make 
tabspace more flexible since most projects have third party code which one 
don't want to change.

TIA.

Original comment by XhmikosR on 24 Aug 2012 at 11:19

GoogleCodeExporter commented 9 years ago

Original comment by tortoisesvn on 25 Aug 2012 at 8:17

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r399.

Original comment by tortoisesvn on 25 Aug 2012 at 8:23

GoogleCodeExporter commented 9 years ago
Thank you! I'll test it later and I'll let you know if I find any issues.

Original comment by XhmikosR on 25 Aug 2012 at 10:31

GoogleCodeExporter commented 9 years ago
After some quick testing I'm not sure this works right...
Example:

tabspace /exclude:thirdparty;include

I would expect tabspace to exclude src/thirdparty and /include folders.

Am I doing something wrong?

Original comment by XhmikosR on 25 Aug 2012 at 11:17

GoogleCodeExporter commented 9 years ago
use
/exclude:*\thirdparty\*;*\include\*

the pattern must match the full path.

Original comment by tortoisesvn on 25 Aug 2012 at 11:21

GoogleCodeExporter commented 9 years ago
I see, this works indeed. Would it be possible to accept the first solution too?

Original comment by XhmikosR on 25 Aug 2012 at 11:26

GoogleCodeExporter commented 9 years ago
that would risk excluding something you don't want excluded:

/exclude:sub1;sub2

would then also exclude
sub1.cpp

or if we only use folders, you couldn't exclude files

Original comment by tortoisesvn on 25 Aug 2012 at 11:34

GoogleCodeExporter commented 9 years ago
I see what you mean but there must be some good way. I know astyle works like 
that when excluding files/folders. I can do --exclude=bin and this would exlude 
only any folder(s) with the name bin and not files. But I can do 
--exclude=resource.h and will exclude all resource.h files found.

Original comment by XhmikosR on 25 Aug 2012 at 11:38

GoogleCodeExporter commented 9 years ago
Sure, it excludes every file or foldername that matches. Problem here is:

dir1\bin\
bin\

you couldn't exclude just the bin\ directory: the dir1\bin directory would also 
be excluded automatically.

I like this solution best: it works in all situations.

Original comment by tortoisesvn on 25 Aug 2012 at 11:42

GoogleCodeExporter commented 9 years ago
All right, it's no big deal, it's just different from most programs I have used.

So as long as one gets that they need to specify the wildcards this way, then 
it's sufficient.

Original comment by XhmikosR on 25 Aug 2012 at 11:49