search

gavro / gulp-iconify

'A mystical CSS icon solution', grunticon-like build system.
MIT License
50 stars 22 forks source link

Use `gulp-sass@^2.0.4` to fix Node v4.2.1 compat #22

Closed aripalo closed 8 years ago

aripalo commented 9 years ago

Support NodeJS v4.2.1 by upgrading gulp-sass depedency to version ^2.0.4 which fixes the error:

./node_modules/gulp-iconify/node_modules/gulp-sass/node_modules/node-sass/lib/index.js:22
    throw new Error('`libsass` bindings not found. Try reinstalling `node-sass`?');
    ^

Error: `libsass` bindings not found. Try reinstalling `node-sass`?
    at getBinding (./node_modules/gulp-iconify/node_modules/gulp-sass/node_modules/node-sass/lib/index.js:22:11)
    at Object.<anonymous> (./node_modules/gulp-iconify/node_modules/gulp-sass/node_modules/node-sass/lib/index.js:188:23)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (./node_modules/gulp-iconify/node_modules/gulp-sass/index.js:3:17)
    at Module._compile (module.js:435:26)
LaurensRietveld commented 9 years ago

ah, didn't see this pull request, and was about to submit one of my own. Much appreciated if this could make it to the next iconify version.

gavro commented 8 years ago

Commit https://github.com/gavro/gulp-iconify/commit/a551d35fef21a191286fe7eb2a1f559a1889e140 fixes this (see pull request #23). Version bumped to 0.4.0.