gavryushkin / curvatureNNI

What is an elementary modification of a discrete time-tree? Exploring the geometry and Ricci-Ollivier curvature of discrete phylogenetic time-trees.
1 stars 0 forks source link

Reviewer 2 minor comments #16

Closed gavryushkin closed 7 years ago

gavryushkin commented 7 years ago
gavryushkin commented 7 years ago

I've gone through these. Could you @cwhidden @matsen have a look? Especially Fig. 2 -- I did try to be super careful but an extra check wouldn't hurt for sure!

gavryushkin commented 7 years ago

I reopen the issue for now -- if you don't feel like I have to do anything extra about these, feel free to close after your pass.

cwhidden commented 7 years ago

I added one comment to your commit that needs to be addressed and rephrased the Page 6 inside Lemma 4 paragraph to say:

"The upper bound is attained by a caterpillar tree with all intervals short, every taxon being younger than every divergence event, and both taxa of the cherry being younger than at least one other taxon, that is, a caterpillar tree with internal nodes having ranks $n, \ldots, 2(n-1)$ and the ranks of the taxa in cherry $< n-1$."

I think part of the reason this was confusing was the negative way it was written "no divergence event being younger than a taxon" so I rephrased it more directly.

cwhidden commented 7 years ago

Looking at the response document, there are many parts where you simply say "Done" or "We have added a detailed explanation" but do not say what the changes were. Unless the reviewer suggested a change (e.g. on Page 6 last paragraph we meant upper bound), I suggest adding the new text to the response document. I did this for my above change, for example.

gavryushkin commented 7 years ago

Thanks @cwhidden! I'll wait for @matsen and then make another pass. Yeah, I was going to expands the done's once we have the final version and the diff -- that way it'll be easier to point out to exact places where we are addressing the concerns.

gavryushkin commented 7 years ago

Got rid of the done's.