search

gavv / httpexpect

End-to-end HTTP and REST API testing for Go.
https://pkg.go.dev/github.com/gavv/httpexpect/v2
MIT License
2.53k stars 237 forks source link

Rename match.Index #408

Closed rafiramadhana closed 1 year ago

rafiramadhana commented 1 year ago

Issue: https://github.com/gavv/httpexpect/issues/252

Rename match.Index to match.Value.

coveralls commented 1 year ago

Coverage Status

Coverage: 95.638%. Remained the same when pulling 9bd427cf721e3be9d69f89e03ecc376febda1cc6 on neverbeenthisweeb:252-rename-index into faca06c55394899e82e6ca9037821581f36377e8 on gavv:master.

gavv commented 1 year ago

@neverbeenthisweeb Hi! Thanks for PR, but see this comment: https://github.com/gavv/httpexpect/pull/320#issuecomment-1452458872

BTW, I have another go project looking for help: https://github.com/roc-streaming/roc-go. Just in case you're interested :)

rafiramadhana commented 1 year ago

@gavv I see, no problem. I am closing this PR. Thanks