search

gavv / httpexpect

End-to-end HTTP and REST API testing for Go.
https://pkg.go.dev/github.com/gavv/httpexpect/v2
MIT License
2.53k stars 237 forks source link

feat(gha): support macos #428

Closed georgettica closed 1 year ago

georgettica commented 1 year ago

related to #413

not sure if someone did or didn't just though that as it's taking for so long I will just start and ask forgiveness if someone has already started and close mine

georgettica commented 1 year ago

not suprisingly, tests fails on windows because I presume file schemas..

I will split this into 2 and do the windows in a different PR, as it requires code changes and I can give value by adding this macos validation now

georgettica commented 1 year ago

also, golangci got a timeout, might be a good idea to cache it to remove issues for the next build?

georgettica commented 1 year ago

GHA windows issue: https://github.com/gavv/httpexpect/actions/runs/6351545303/job/17252937458

github-actions[bot] commented 1 year ago

:umbrella: The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts.

gavv commented 1 year ago

Hi, thanks for PR, but we already had one: #426

georgettica commented 1 year ago

I am glad it's closed :)