gavv / signal-estimator

Measure characteristics of a looped back signal.
MIT License
67 stars 20 forks source link

Detect light/dark theme and set plot background #70

Closed gavv closed 1 year ago

gavv commented 1 year ago

Earlier we unconditionally used white background color for plots. It looks fine with light system theme, but not with dark theme.

After #54 we're now using default system color for plots. It looks fine for dark theme, and is tolerable for light theme. However, using white background would still look better for light themes.

Here is how it looks on light theme now:

image

Probably we could somehow detect whether we're on light or dark theme (e.g. at least we could check "lightness" of default color) and depending on that decide what color to use for plot backgrounds: white or dark.

gavv commented 1 year ago

Landed