Upgrade to pion/webrtc@v3

Sean-Der commented 3 years ago

Hey @gavv

We released v3 would you be open to a PR porting webrtc-cli?

I will have to make some changes for the new Track API and Trickle ICE being enabled by default. It requires no real refactoring though just changes to the names of functions.

thanks!

gavv commented 3 years ago

Hi, sure, PRs are welcome! Thanks for taking care of it!

gavv commented 3 years ago

I've pushed the first attempt to branch pion3. See last commit: fa89a62df26e513cc1c5ac752b90666c1a600873

It's compiling, but not working yet. I think the problem is with newMediaEngineFromOffer() function. This function creates MediaEngine from an SDP offer. Later I pass this media engine to the API object.

newMediaEngineFromOffer() does three things:

calls populateFromSDP(), which replicates webrtc.MediaEngine.PopulateFromSDP from v2, but with some differences (to be honest, I don't remember why I had to do it)
validates parameters of the offered audio codec (it should be opus, have right sample rate, etc)
determines whether opus FEC is enabled in the offer

I guess that this workflow is not valid anymore in v3.

@Sean-Der I'm going to look into it further, but if you know how to fix it and would like to do it, or just have some hints, you're welcome! Please let me know.

gavv / webrtc-cli

Upgrade to pion/webrtc@v3 #9