search

gawati / gawati-portal-ui

Version 2 of the gawati portal
GNU Affero General Public License v3.0
0 stars 0 forks source link

i18n - convert all literal strings to i18n prefixed strings #14

Closed kohsah closed 6 years ago

kohsah commented 6 years ago

Currently many texts are literal : 

            <li><strong>Document Number:</strong> {anFRBRnumber(doc, type).showAs}</li>

This needs to be translation prefixed : 

            <li><strong>T("Document Number:")</strong> {anFRBRnumber(doc, type).showAs}</li>

and the String needs to be added to translations.json (in english)

kohsah commented 6 years ago
  1. Dates need to be localized as per locale
  2. Country names in filter dropdown need to be localized
Arunadevi commented 6 years ago

What about countries and languages above the thumbnail? image

kohsah commented 6 years ago

@Arunadevi Same applies to those. They need to be localized too.

Arunadevi commented 6 years ago

Updated issue-#34 branch. Please let me know if I should rename the branch. (This is just an update on the issue. Will review the fix once again tomorrow)