search

gawati / gawati-portal-ui

Version 2 of the gawati portal
GNU Affero General Public License v3.0
0 stars 0 forks source link

filter tab on mobile stays on top #58

Open ccsmart opened 6 years ago

ccsmart commented 6 years ago

On mobile. The filter configuration side bar stays on top of the website, covering the rest of the UI / doesn't scroll out in some way.

Arunadevi commented 6 years ago

screenshot_20180321-130301 The burger menu button can be used to toggle the filter menu.

ccsmart commented 6 years ago

In this case, default toggle should be off. On my screen, the initial size of the menu is different from the size when switched off/ back on. It is a little smaller than max width on first render, a llittle too wide in later activations. Is it the same for you ?

Arunadevi commented 6 years ago

Is it the same for you ?

Yes.

In this case, default toggle should be off.

I'm enabling swipeout for the filter container additionally. Will set default to off.

kohsah commented 6 years ago

@Arunadevi Not sure if this is a bug or not ---

I tested on different simulators... iphone 8, 7 etc. seemed fine. This is for the default theme. Kenya theme was fine across all.

on the nexus simulator (android) :

image

image

Arunadevi commented 6 years ago

I've noticed this too. I was having to scroll/swipe horizontally sometimes to view end to end on the simulator. However, when accessed from the mobile itself, it was fine. The scenario is not reproducible consistently:

On Fri, Mar 23, 2018 at 11:22 AM, Ashok H notifications@github.com wrote:

@Arunadevi https://github.com/arunadevi Not sure if this is a bug or not ---

I tested on different simulators... iphone 8, 7 etc. seemed fine. This is for the default theme. Kenya theme was fine across all.

on the nexus simulator (android) :

[image: image] https://user-images.githubusercontent.com/5685392/37813691-4735b4b6-2e8c-11e8-8bf5-caa4c960ca13.png

[image: image] https://user-images.githubusercontent.com/5685392/37813711-5e51d9e0-2e8c-11e8-9c4d-a02a6e5bcb32.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gawati/gawati-portal-ui/issues/58#issuecomment-375552686, or mute the thread https://github.com/notifications/unsubscribe-auth/ADnEEErmO9p4lU7I8hFPIP2K47RE9qcaks5thI2UgaJpZM4Sx66U .

kohsah commented 6 years ago

@Arunadevi Yeah not consistent for me either in the simulator. Please set the status to "fixed test pending"

ccsmart commented 6 years ago

default still on, should be off by default

ccsmart commented 6 years ago

default seems off / fixed now. The filter window is still a bit wide. Particularly the little down arrow indicating the dropdown function is outside the visible area to the right. So if you dont know, you might miss the idea until you try.